[core] Do not pushdown limit when non partition filter is present#7665
Merged
JingsongLi merged 10 commits intoapache:masterfrom Apr 17, 2026
Merged
[core] Do not pushdown limit when non partition filter is present#7665JingsongLi merged 10 commits intoapache:masterfrom
JingsongLi merged 10 commits intoapache:masterfrom
Conversation
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
Contributor
Author
|
@wwj6591812 Could you please help take a look at this PR. |
JingsongLi
reviewed
Apr 17, 2026
| @@ -126,7 +132,7 @@ public List<PartitionEntry> listPartitionEntries() { | |||
| } | |||
|
|
|||
| private Optional<StartingScanner.Result> applyPushDownLimit() { | |||
Contributor
There was a problem hiding this comment.
Maybe this should be in SnapshotReaderImpl, withFilter already know if there is non-part filter. (!pair.getRight().isEmpty())
Contributor
Author
There was a problem hiding this comment.
Maybe this should be in
SnapshotReaderImpl,withFilteralready know if there is non-part filter. (!pair.getRight().isEmpty())
Updated
Contributor
|
+1 |
XiaoHongbo-Hope
added a commit
that referenced
this pull request
Apr 19, 2026
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
If limit pushdown is applied before non-partition filters are evaluated, scanning may stop too early and return fewer rows than requested. To fix this, limit pushdown is disabled when non-partition filters exist.
Tests